Skip to content

Add missing target dependency #9008

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Add missing target dependency #9008

wants to merge 1 commit into from

Conversation

bkhouri
Copy link
Contributor

@bkhouri bkhouri commented Aug 8, 2025

No description provided.

@bkhouri
Copy link
Contributor Author

bkhouri commented Aug 8, 2025

@swift-ci test

@bkhouri bkhouri enabled auto-merge (squash) August 8, 2025 20:14
@bkhouri
Copy link
Contributor Author

bkhouri commented Aug 9, 2025

Swift Test Windows Platform build has a test failure unrelated to this change

Failed Tests (1):
  lldb-api :: tools/lldb-dap/launch/TestDAP_launch.py

Retriggering

@swift-ci test windows

@bkhouri
Copy link
Contributor Author

bkhouri commented Aug 9, 2025

@swift-ci test self hosted windows

@bripeticca
Copy link
Contributor

@swift-ci please test self hosted windows

@bkhouri
Copy link
Contributor Author

bkhouri commented Aug 11, 2025

The Windows Self hosted pipeline failed with the following

13:27:42  Test Suite 'Selected tests' started at 2025-08-11 15:50:23.026
13:27:42  Test Suite 'AsyncProcessTests' started at 2025-08-11 15:50:23.030
13:27:42  Test Case 'AsyncProcessTests.testPopenWithBufferLargerThanAllocated' started at 2025-08-11 15:50:23.030
13:27:42  <EXPR>:0: error: AsyncProcessTests.testPopenWithBufferLargerThanAllocated : threw error "invalid access to C:\Users\ContainerAdministrator\AppData\Local\Temp\TemporaryFile.MlqI0K"
13:27:42  Test Case 'AsyncProcessTests.testPopenWithBufferLargerThanAllocated' failed (0.016 seconds)
13:27:42  Test Suite 'AsyncProcessTests' failed at 2025-08-11 15:50:23.046
13:27:42  	 Executed 1 test, with 1 failure (1 unexpected) in 0.016 (0.016) seconds
13:27:42  Test Suite 'Selected tests' failed at 2025-08-11 15:50:23.046
13:27:42  	 Executed 1 test, with 1 failure (1 unexpected) in 0.016 (0.016) seconds

I don't see how this is related to the change. I'm retriggering the build

@swift-ci test self hosted windows

@bripeticca
Copy link
Contributor

seeing the same failure again, going to retrigger the build once more.

@swift-ci please test self hosted windows

@bkhouri bkhouri force-pushed the t/main/add_missing_target_dep branch from b9f52a7 to dc00335 Compare August 12, 2025 02:21
@bkhouri
Copy link
Contributor Author

bkhouri commented Aug 12, 2025

@swift-ci please test

@bkhouri
Copy link
Contributor Author

bkhouri commented Aug 12, 2025

@swift-ci test windows

@bkhouri
Copy link
Contributor Author

bkhouri commented Aug 12, 2025

@swift-ci test self hosted

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jakepetroules jakepetroules jakepetroules approved these changes

@owenv owenv owenv approved these changes

@dschaefer2 dschaefer2 Awaiting requested review from dschaefer2 dschaefer2 is a code owner

@shawnhyam shawnhyam Awaiting requested review from shawnhyam shawnhyam is a code owner

@bripeticca bripeticca Awaiting requested review from bripeticca bripeticca is a code owner

@plemarquand plemarquand Awaiting requested review from plemarquand plemarquand is a code owner

@cmcgee1024 cmcgee1024 Awaiting requested review from cmcgee1024 cmcgee1024 is a code owner

@daveyc123 daveyc123 Awaiting requested review from daveyc123 daveyc123 is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@bkhouri @bripeticca @jakepetroules @owenv