Tests: Migrate PackageCommandTests to Swift Testing and Augment #9012
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci test |
bkhouri
added a commit
to bkhouri/swift-package-manager
that referenced
this pull request
Aug 11, 2025
Migrate the `BuildSystemDelegateTests` test to Swift Testing and augment the test to run against both the Native and SwiftBUild build system, in addition to the `debug`` and `release` build configuration. Depends on: swiftlang#9012 Relates to: swiftlang#8997 issue: rdar://157669245
cmcgee1024
reviewed
Aug 12, 2025
| } | ||
| } | ||
| } when: { | ||
| (ProcessInfo.hostOperatingSystem == .windows && data.buildSystem == .swiftbuild && !withPrettyPrinting) |
There was a problem hiding this comment.
suggestion (non-blocking): The known issue is with windows and the swiftbuild build system. I expect that the pretty printing doesn't impact this check at all, so I would remove the check whether pretty printing is not enabled.
cmcgee1024
approved these changes
Aug 12, 2025
bkhouri
added a commit
to bkhouri/swift-package-manager
that referenced
this pull request
Aug 12, 2025
Migrate a few suites to Swift Teting, namely, - SwiftSDKCommandTests - MultiRootSupportTests - SwiftCommandStateTests Depends on: swiftlang#9012 Relates to: swiftlang#8997 issue: rdar://157669245
bkhouri
added a commit
to bkhouri/swift-package-manager
that referenced
this pull request
Aug 12, 2025
Migrate a few suites to Swift Teting, namely, - SwiftSDKCommandTests - MultiRootSupportTests - SwiftCommandStateTests Depends on: swiftlang#9012 Relates to: swiftlang#8997 issue: rdar://157669245
bkhouri
force-pushed
the
t/main/gh8997_rdar157669245_migrate-packacage_command_tests_to_ST
branch
from
37217a5 to
d505742
Compare
|
@swift-ci test |
Migrate the `PackageCommandTests` to Swift Testing and augment the suite to run against the Native and SwiftBuild build system, in addition to the `debug` and `release` build configurations. Relates to: swiftlang#8997 issue: rdar://157669245
bkhouri
force-pushed
the
t/main/gh8997_rdar157669245_migrate-packacage_command_tests_to_ST
branch
from
d505742 to
0e692c0
Compare
|
@swift-ci test |
|
@swift-ci test windows |
This was referenced Aug 13, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Migrate the
PackageCommandTeststo Swift Testing and augment the suite to run against the Native and SwiftBuild build system, in addition to thedebugandreleasebuild configurations.Relates to: #8997
issue: rdar://157669245