[6.1] Frequent crashes in LLBuildProgressTracker while building swift-java on linux and swift 6.1.2 #9019
+21
−15
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Explanation:
(cherry picked from commit 16452e1)
Frequent crashes in LLBuildProgressTracker while building swift-java on linux and swift 6.1.2
Command is associated with a handle (pointer) that may be reclaimed when this function finishes.
Scope:
Minimal
Issues:
swiftlang/swift-java#314
Original PRs:
#8998
Risk:
Minimal. Change explicitly copies variables prior to usage in async block.
Change has been tested in main and 6.2
Testing:
Confirmed fixed in main and 6.2