[Commands] Adopt changes to package manifest refactoring actions #9064
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously package manifest refactoring actions conformed to a custom refactoring provider and produced a `PackageEdit` that, in addition to manifest file changes, included a list of auxiliary files. This is no longer the case and all package manifest refactoring actions are now responsible only for manifest file transformations, the rest is handled by the commands themselves.
xedin
requested review from
bkhouri,
bripeticca,
cmcgee1024,
daveyc123,
dschaefer2,
jakepetroules,
owenv,
plemarquand and
shawnhyam
as code owners
|
Depends on swiftlang/swift-syntax#3143 |
bnbarham
approved these changes
Aug 26, 2025
owenv
approved these changes
Aug 26, 2025
|
swiftlang/sourcekit-lsp#2262 |
|
swiftlang/swift-syntax#3143 |
|
swiftlang/swift-syntax#3143 |
|
swiftlang/swift-syntax#3143 |
|
swiftlang/swift-syntax#3143 |
2 similar comments
|
swiftlang/swift-syntax#3143 |
|
swiftlang/swift-syntax#3143 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation:
Previously package manifest refactoring actions conformed to a custom refactoring provider and produced a
PackageEditthat, in addition to manifest file changes, included a list of auxiliary files. This is no longer the case and all package manifest refactoring actions are now responsible only for manifest file transformations, the rest is handled by the commands themselves.Modifications:
textRefactorinstead of (now removed) `manifestRefactor.applyEditsto be on[SourceEdit]instead of a custom type.