Fix macros that depend on libraries that also depend on swift-syntax #9206
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously the library would be built from source and then link together with the prebuilt to create the macro executable. That causes a crash in the macro. This change extends what we build using the prebuilt to all targets when built for host. It will continue to build from source when targets are built for destination. This will include plugin tools as well. The separation of build output between host and destination (which is potentially a different platform) makes this work. This is accomplished by recording in the BuildEnvironment whether the destination was host and the adding in an internal HostCondition that checks it in it's satisfy method.
dschaefer2
requested review from
jakepetroules,
shawnhyam,
bripeticca,
plemarquand,
owenv,
bkhouri,
cmcgee1024,
daveyc123 and
rconnell9
as code owners
|
@swift-ci please test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously the library would be built from source and then link together with the prebuilt to create the macro executable. That causes a crash in the macro when building for debug (the prebuilts were built for release).
This change extends what we build using the prebuilt to all targets when built for host. It will continue to build from source when targets are built for destination. This will include plugin tools as well. The separation of build output between host and destination (which is potentially a different platform) makes this work.
This is accomplished by recording in the BuildEnvironment whether the destination was host and the adding in an internal HostCondition that checks it in it's satisfy method.