Skip to content

Use new common object product type in PIF #9216

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
+3 −7
Open

Use new common object product type in PIF #9216

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions Sources/SwiftBuildSupport/PackagePIFBuilder.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -358,7 +358,7 @@ public final class PackagePIFBuilder {
// Products.
case application
case staticArchive
case objectFile
case commonObject
case dynamicLibrary
case framework
case executable
Expand All @@ -382,7 +382,7 @@ public final class PackagePIFBuilder {
self = switch pifProductType {
case .application: .application
case .staticArchive: .staticArchive
case .objectFile: .objectFile
case .commonObject: .commonObject
case .dynamicLibrary: .dynamicLibrary
case .framework: .framework
case .executable: .executable
Expand Down
6 changes: 1 addition & 5 deletions Sources/SwiftBuildSupport/PackagePIFProjectBuilder+Modules.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -249,11 +249,7 @@ extension PackagePIFProjectBuilder {
}

case .staticLibrary, .executable:
#if os(Windows) // Temporary until we get a new productType in swift-build
productType = .staticArchive
#else
productType = .objectFile
#endif
productType = .commonObject

case .macro:
productType = .hostBuildTool
Expand Down