Skip to content

Conversation

euanh
Copy link
Contributor

@euanh euanh commented Jun 17, 2025

Some Shell.run() calls do not quote paths, so paths which include spaces are not handled properly.

@euanh euanh changed the title tests: Include spaces in temporary build directory paths Handle spaces SDK build paths Jun 17, 2025
@euanh euanh changed the title Handle spaces SDK build paths Handle spaces in SDK build paths Jun 17, 2025
@euanh
Copy link
Contributor Author

euanh commented Jun 17, 2025

@swift-ci test

@euanh euanh force-pushed the deb-build-paths-with-spaces branch from 82d5f90 to 9e1afa2 Compare June 17, 2025 12:35
@euanh
Copy link
Contributor Author

euanh commented Jun 17, 2025

@swift-ci test

Copy link
Contributor

@MaxDesiatov MaxDesiatov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great catch, thanks!

@euanh euanh marked this pull request as ready for review June 18, 2025 12:18
@euanh euanh merged commit 6fd0ada into swiftlang:main Jun 18, 2025
21 checks passed
@euanh euanh deleted the deb-build-paths-with-spaces branch June 18, 2025 12:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants