Add missing libcurl4-openssl-dev dependency in Ubuntu/Debian packages, add more EndToEnd testcases #236
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Created list of commonPackages for both distros to share dependencies between releases.
|
@swift-ci test |
|
Hmm, maybe that task group is not going to work too well. I can revert that piece if it's going to be an issue with 5.9. |
|
We're likely very close to dropping support for 5.9 at this point, 5.10 issues are more important to resolve. |
|
@swift-ci test |
euanh
approved these changes
Aug 19, 2025
|
@swift-ci test macos |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As outlined in #197, the generator was not downloading the needed
libcurl4-openssl-devdependency that is required to statically linkFoundationNetworkingwith--static-swift-stdlib.This PR adds the needed dependency for all supported Ubuntu and Debian versions with a little bit of refactoring in
LinuxDistribution.swiftto reduce duplication of common dependencies across versions.I also added an additional testcase in the
EndToEndTeststo verify this curl dependency is available and works. With this change is some improvements to the logging of the EndToEndTests, so we end up with the following output:If you notice in the above, we now have:
@euanh @MaxDesiatov