-
Notifications
You must be signed in to change notification settings - Fork 20
Bump swift-tools-version
to 6.0
#237
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Since we're no longer directly testing with Swift 5.9 and 5.10, let's try to bump `swift-tools-version` to 6.0 to declare that these older versions are no longer supported.
@swift-ci test |
With this change, can the |
Yes, I'll update #190 after this one's merged. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I understand this change is relatively low-risk, but if you don’t have any immediate need for 6.0 language features, would you mind holding it off until I merge swiftwasm/swiftwasm-build#627 ? (I'm trying to merge it this week)
Recent changes around build-runtime-with-host-compiler have broken the build, and I’d really prefer not to juggle multiple issues at the same time.
Sure, I'll keep this open until then. Sorry about the breakage 😢 |
As Swift CI nodes use Swift 5.9 and Swift 5.10, and as of swiftlang/swift-sdk-generator#227 Swift SDK Generator is no longer tested with Swift 5.9 and 5.10, we should build it with the freshly built toolchain. This will also unblock bump of `swift-tools-version` to 6.0 in the generator's package swiftlang/swift-sdk-generator#237
Depends on swiftlang/swift#83808.
Since we're no longer directly testing with Swift 5.9 and 5.10, let's try to bump
swift-tools-version
to 6.0 to declare that these older versions are no longer supported.