Skip to content

Add Debian 12 (Bookworm) support #139

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions .github/workflows/pull_request.yml
Original file line number Diff line number Diff line change
Expand Up @@ -9,10 +9,10 @@ jobs:
name: Test
uses: swiftlang/github-workflows/.github/workflows/swift_package_test.yml@main
with:
linux_os_versions: '["noble", "jammy", "focal", "rhel-ubi9"]'
linux_os_versions: '["noble", "jammy", "focal", "rhel-ubi9", "bookworm"]'
linux_swift_versions: '["6.1", "nightly-main"]'
linux_pre_build_command: |
if command -v apt-get >/dev/null 2>&1 ; then # noble, jammy, focal
if command -v apt-get >/dev/null 2>&1 ; then # noble, jammy, focal, or bookworm
apt-get update -y

# Test dependencies
Expand Down
1 change: 1 addition & 0 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -232,6 +232,7 @@ The table below describes the current level of support that Subprocess has for v
| **Ubuntu 22.04** | Supported |
| **Ubuntu 24.04** | Supported |
| **Red Hat Universal Base Image 9** | Supported |
| **Debian 12** | Supported |
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there much point listing individual Linux distributions versus just saying "Linux"? It's implied to be "whatever Swift itself supports".

Besides, it's really "Glibc" and "Musl" that we support; there is nothing at the distribution level that swift-subprocess is aware of. Just the kernel and the libc.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wondered about this myself. Because subprocess is a package, I suppose that it must be built on host where a supported toolchain can exist, and therefore can probably claim that it supports every Linux that has a supported toolchain. This can be different than the supported deployment platforms, which might be based on Glibc/Musl versions?

| **Windows** | Supported |

<p align="right">(<a href="#readme-top">back to top</a>)</p>
Expand Down