Call spawn() on a background thread because it might block #158
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iCharlesHu
force-pushed
the
charles/async-spawn
branch
from
87269bf to
fd53084
Compare
iCharlesHu
force-pushed
the
charles/async-spawn
branch
from
fd53084 to
4d58af5
Compare
Introduce runOnBackgroundThread() to run closures on a background thread without blocking the Swift Concurrency thread pool
iCharlesHu
force-pushed
the
charles/async-spawn
branch
from
4d58af5 to
334e6c3
Compare
iCharlesHu
force-pushed
the
charles/async-spawn
branch
from
334e6c3 to
58445d9
Compare
jakepetroules
approved these changes
Sep 2, 2025
Agreed. I'll disable this test |
…we can't safely write to / read from a closed fd
iCharlesHu
force-pushed
the
charles/async-spawn
branch
from
9074cbf to
0faf723
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Introduce
runOnBackgroundThread()to run closures on a background thread without blocking the Swift Concurrency thread pool.On Darwin,
runOnBackgroundThread()usesDispatchQueue; on Linux and Windows, it uses a single thread in the work loop.Resolves: #85