Skip to content

Add extern "C" to header process_shims.h #195

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 4, 2025
Merged

Add extern "C" to header process_shims.h #195

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 16 additions & 0 deletions Sources/_SubprocessCShims/include/process_shims.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,6 +35,10 @@
#include <sys/wait.h>
#endif // TARGET_OS_LINUX || TARGET_OS_FREEBSD

#ifdef __cplusplus
extern "C" {
#endif

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wonder if this would be better served with a:

extern "C" {

block rather than annotating each of the declarations.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's what I originally had, and then I saw #include <Windows.h> and realized I couldn't just wrap the entire thing with extern "C".

... But on second thought, I could just hoist that up to the top, and do the extern "C" thing you suggest (which is a cleaner patch).

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Right, as long as the includes come outside of the block, it is simpler. That also avoids the pitfall of missing the annotation on a future declaration.

#if __has_include(<mach/vm_page_size.h>)
vm_size_t _subprocess_vm_size(void);
#endif
Expand Down Expand Up @@ -102,12 +106,20 @@ int _pidfd_open(pid_t pid);

#endif

#ifdef __cplusplus
} // extern "C"
#endif

#endif // !TARGET_OS_WINDOWS

#if TARGET_OS_WINDOWS

#include <Windows.h>

#ifdef __cplusplus
extern "C" {
#endif

#ifndef _WINDEF_
typedef unsigned long DWORD;
typedef int BOOL;
Expand All @@ -122,6 +134,10 @@ unsigned int _subprocess_windows_get_errno(void);
/// complex macro and cannot be imported directly into Swift.
DWORD_PTR _subprocess_PROC_THREAD_ATTRIBUTE_HANDLE_LIST(void);

#ifdef __cplusplus
} // extern "C"
#endif

#endif

#endif /* process_shims_h */