Emulate POSIX_SPAWN_CLOEXEC_DEFAULT in fork/exec #79
Conversation
iCharlesHu
force-pushed
the
charles/fork-exec-close-fd
branch
from
6e9afb5 to
3e47e05
Compare
iCharlesHu
force-pushed
the
charles/fork-exec-close-fd
branch
from
3e47e05 to
2d9a937
Compare
| hi = getdtablesize(); | ||
| } | ||
| #else | ||
| int hi = 1024; |
There was a problem hiding this comment.
Where does '1024' come from and how safe is it to default to this vs making this #error and requiring a specific implementation for new platforms?
Also, the following additional platforms support getdtablesize: FreeBSD, OpenBSD, NetBSD, Solaris, QNX.
There was a problem hiding this comment.
Instead of #error, how about if I just call getdtablesize unconditionally here and have it naturally error on platforms that don't support it.
|
FreeBSD PR #1698 adds support for POSIX O_CLOFORK, which could simplify this implementation. |
Ahh thanks. Good to know. |
iCharlesHu
force-pushed
the
charles/fork-exec-close-fd
branch
from
2d9a937 to
cd79141
Compare
| char * _Nullable const args[_Nonnull], | ||
| char * _Nullable const env[_Nullable], | ||
| gid_t * _Nullable process_group_id | ||
| int _shims_snprintf( |
There was a problem hiding this comment.
On Linux this function isn't exposed via import Glibc
iCharlesHu
force-pushed
the
charles/fork-exec-close-fd
branch
from
cd79141 to
c217b39
Compare
|
Addressed review comments. |
|
Just a heads up - the PR has merged. I think the timing means it'll likely make it into the upcoming FreeBSD 15 release in December. |
There was a problem hiding this comment.
The Linux CI failure looks relevant
[7/22] Compiling CSystem shims.c
/__w/swift-subprocess/swift-subprocess/Sources/_SubprocessCShims/process_shims.c:318:28: error: use of undeclared identifier 'val'
318 | if (errno == ERANGE || val <= 0 || val > INT_MAX) {
|
| &file_actions, file_descriptors[2], STDOUT_FILENO | ||
| ); | ||
| if (rc != 0) { return rc; } | ||
| if (errno == ERANGE || val <= 0 || val > INT_MAX) { |
There was a problem hiding this comment.
I think this is what's causing the Linux CI failure
[7/22] Compiling CSystem shims.c
/__w/swift-subprocess/swift-subprocess/Sources/_SubprocessCShims/process_shims.c:318:28: error: use of undeclared identifier 'val'
318 | if (errno == ERANGE || val <= 0 || val > INT_MAX) {
Should be value instead?
|
Now that O_CLOFORK is merged in all *BSD, work can be started on support O_CLOFORK flags. |
POSIX_SPAWN_CLOEXEC_DEFAULT is only available on Darwin. Emulate POSIX_SPAWN_CLOEXEC_DEFAULT on other platforms by calling close after fork, before exec. This commit also removes _subprocess_posix_spawn_fallback because we can't emulate POSIX_SPAWN_CLOEXEC_DEFAULT in a thread-safe manner while using posix_spawn.
iCharlesHu
force-pushed
the
charles/fork-exec-close-fd
branch
from
c217b39 to
769ea70
Compare
iCharlesHu
force-pushed
the
charles/fork-exec-close-fd
branch
from
769ea70 to
e791d2e
Compare
POSIX_SPAWN_CLOEXEC_DEFAULT is only available on Darwin. Emulate POSIX_SPAWN_CLOEXEC_DEFAULT on other platforms by calling close after fork, before exec.
This commit also removes _subprocess_posix_spawn_fallback because we can't emulate POSIX_SPAWN_CLOEXEC_DEFAULT in a thread-safe manner while using posix_spawn.
Resolves: #46