Use root node for detached node lookup in location retrieval #2792
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ahoppen
reviewed
Aug 8, 2024
Sources/SwiftSyntaxMacroExpansion/BasicMacroExpansionContext.swift
Outdated
Show resolved
Hide resolved
mateusrodriguesxyz
force-pushed
the
root-detached-node
branch
from
9f76064 to
75177e0
Compare
ahoppen
approved these changes
Aug 9, 2024
|
@swift-ci Please test |
|
Thanks for fixing this @mateusrodriguesxyz! 🙏🏽 |
|
@mateusrodriguesxyz still seeing this erroneous behavior for attributes of a functionDeclSyntax, I'll write up a test and see if I can't amend the context, see #3056 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2791
Maybe just
let nodeInOriginalTree = sharedState.detachedNodes[Syntax(node.root)]is sufficient? I tried and no existing tests failed.