[Parser] Remove abiAttribute experimental feature
#3025
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
swiftlang/swift#80168 |
rintaro
force-pushed
the
remove-feature-abi-attribute
branch
from
73cdad8 to
a164ab6
Compare
But `ABIAttributeArgumentsSyntax` is still under `@_spi(ExperimentalLanguageFeatures)`. Not parsing the interior of `@abi` attribute causes catastrophic breakage to the tree. Having "unknown" syntax kind in the tree is better than dealing with structually broken trees.
rintaro
force-pushed
the
remove-feature-abi-attribute
branch
from
a164ab6 to
6deb1ff
Compare
|
swiftlang/swift#80168 |
|
swiftlang/swift#80168 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
But
ABIAttributeArgumentsSyntaxis still under@_spi(ExperimentalLanguageFeatures).Not parsing the interior of
@abiattribute causes catastrophic breakage to the tree. Having "unknown" syntax kind in the tree is better than dealing with structually broken trees.