Skip to content

Removes duplicate trivia from UnsafeExprSyntax #3043

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 9, 2025
Merged

Removes duplicate trivia from UnsafeExprSyntax #3043

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 1 addition & 3 deletions Sources/SwiftOperators/OperatorTable+Folding.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -141,7 +141,6 @@ extension OperatorTable {
if let unsafeExpr = lhs.as(UnsafeExprSyntax.self) {
return ExprSyntax(
UnsafeExprSyntax(
leadingTrivia: unsafeExpr.leadingTrivia,
unsafeExpr.unexpectedBeforeUnsafeKeyword,
unsafeKeyword: unsafeExpr.unsafeKeyword,
unsafeExpr.unexpectedBetweenUnsafeKeywordAndExpression,
Expand All @@ -150,8 +149,7 @@ extension OperatorTable {
op: op,
rhs: rhs
),
unsafeExpr.unexpectedAfterExpression,
trailingTrivia: unsafeExpr.trailingTrivia
unsafeExpr.unexpectedAfterExpression
)
)
}
Expand Down
6 changes: 6 additions & 0 deletions Tests/SwiftOperatorsTest/OperatorTableTests.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -435,4 +435,10 @@ class OperatorPrecedenceTests: XCTestCase {
}

}

func testTriviaAroundUnsafeExpr() throws {
let original = ExprSyntax("/*leading*/ unsafe a /*trailing*/ + b")
let folded = try OperatorTable.standardOperators.foldAll(original)
XCTAssertEqual(original.description, folded.description)
}
}