.swift-format: Specify an exhaustive configuration #3117
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AnthonyLatsis
requested review from
DougGregor,
ahoppen,
bnbarham,
hamishknight and
rintaro
as code owners
Unexpectedly, an omitted rule tells swift-format to ignore it altogether rather than assume the default setting. This change applies the default configuration, retaining current settings and disabling 3 default-enabled rules: `DoNotUseSemicolons`, `NoAccessLevelOnExtensionDeclaration`, and `DontRepeatTypeInStaticProperties`. The latter is disabled due to undesired effect: ``` warning: [DontRepeatTypeInStaticProperties] remove the suffix 'Paths' from the name of the variable 'envSearchPaths' ```
|
@swift-ci please test |
|
@swift-ci please test macOS |
bnbarham
approved these changes
Aug 8, 2025
ahoppen
added a commit
to ahoppen/sourcekit-lsp
that referenced
this pull request
Aug 11, 2025
Apply the exhaustive swift-format configuration from swiftlang/swift-syntax#3117 to sourcekit-lsp. Also apply all automatic formattings.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Unexpectedly, an omitted rule tells swift-format to ignore it altogether rather than assume the default setting.
This change applies the default configuration, retaining current settings and disabling 3 default-enabled rules:
DoNotUseSemicolons,NoAccessLevelOnExtensionDeclaration, andDontRepeatTypeInStaticProperties. The latter is disabled due to undesired effect: