Skip to content

[6.2] FixItApplier: Misc improvements to FixItApplier.apply #3123

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Jul 8, 2025

Conversation

AnthonyLatsis
Copy link
Contributor

  • Explanation:
    • Tests (we didn’t have any).
    • Optimizations.
    • Bug fix: an insertion can conflict with another edit.
    • Control over whether to skip duplicate insertions. In swift package migrate, this will enable us to prevent repeated fix-it application in various scenarios where multiple elements in a protocol composition type are diagnosed with the same insertion fix-it.
  • Scope: The FixItApplier SPI, used by internal testing facilities and in SwiftPM by swift package migrate and the various swift package add-* commands.
  • Issues: —
  • Original PRs: FixItApplier: Misc improvements #3121.
  • Risk: Low.
  • Testing: Added regression tests for both the existing implementation and the changes.
  • Reviewers: @ahoppen

@AnthonyLatsis AnthonyLatsis requested a review from a team as a code owner July 8, 2025 11:28
@AnthonyLatsis
Copy link
Contributor Author

@swift-ci please test

@AnthonyLatsis
Copy link
Contributor Author

@swift-ci please test Windows

@AnthonyLatsis AnthonyLatsis enabled auto-merge July 8, 2025 19:48
@AnthonyLatsis AnthonyLatsis merged commit a0db756 into release/6.2 Jul 8, 2025
27 checks passed
@AnthonyLatsis AnthonyLatsis deleted the jepa2-6.2 branch July 8, 2025 20:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants