[SwiftRefactor] PackageManifest: Make a couple of properties external… #3139
+20
−24
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xedin
requested review from
ahoppen,
bnbarham,
hamishknight and
rintaro
as code owners
bnbarham
reviewed
Aug 13, 2025
Comment on lines
337
to
338
| @_spi(PackageRefactor) | ||
| public extension PackageTarget { |
There was a problem hiding this comment.
Any reason to keep this one as an extension and not name? I'd probably just move it as well
There was a problem hiding this comment.
Sure, there is localizedFirstWordCapitalized but we can deal with that later.
…ly accessible In it's current state `AddPackageTarget` does multiple things: 1. Updates the manifest to introduce new targets and dependencies. 2. Generates one or more auxiliary files depending on the type of target being added (i.e. a primary file for the target and sometimes a macro specific defintions file). We'd like to scope the refactoring action down to manifest updates only. The callers are going to be resposble for swiftlang#2 from the list. In order to do that `PackageTarget.sanitizedName` and `PackageTarget.Dependency.name` have to be externally accessible (under `@_spi(PackageRefactor)` still) to form the content of the file.
xedin
force-pushed
the
make-name-package-target-name-and-sanitized-name-accessible
branch
from
680659b to
f807ce6
Compare
bnbarham
approved these changes
Aug 13, 2025
|
@swift-ci please test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…ly accessible
In it's current state
AddPackageTargetdoes multiple things:Updates the manifest to introduce new targets and dependencies.
Generates one or more auxiliary files depending on the type of target being added (i.e. a primary file for the target and sometimes a macro specific defintions file).
We'd like to scope the refactoring action down to manifest updates only.
The callers are going to be resposble for #2 from the list. In order to do that
PackageTarget.sanitizedNameandPackageTarget.Dependency.namehave to be externally accessible (under@_spi(PackageRefactor)still) to form the content of the file.