Use Invoke-Program for the Windows build command
#3140
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Windows does not stop scripts when native commands exit with non-zero. Instead, their exit status has to be checked manually. This can be done through an `Invoke-Program` function that is added to the script running `windows_build_command`, which also previously prefixed the given command. This is changing in swiftlang/github-workflows#154 since it doesn't help with multi-line commands - update our modified `windows_build_command` to use `Invoke-Program` instead.
bnbarham
requested review from
ahoppen,
hamishknight and
rintaro
as code owners
|
@swift-ci test |
jakepetroules
approved these changes
Aug 22, 2025
|
@swift-ci please test Linux platform |
ahoppen
approved these changes
Aug 22, 2025
|
@swift-ci Please test Windows |
3 similar comments
|
@swift-ci Please test Windows |
|
@swift-ci Please test Windows |
|
@swift-ci Please test Windows |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Windows does not stop scripts when native commands exit with non-zero. Instead, their exit status has to be checked manually. This can be done through an
Invoke-Programfunction that is added to the script runningwindows_build_command, which also previously prefixed the given command. This is changing inswiftlang/github-workflows#154 since it doesn't help with multi-line commands - update our modified
windows_build_commandto useInvoke-Programinstead.