Add Documentation to Closure & Await Syntax Nodes#3271
Open
nazaralwi wants to merge 2 commits intoswiftlang:mainfrom
Open
Add Documentation to Closure & Await Syntax Nodes#3271nazaralwi wants to merge 2 commits intoswiftlang:mainfrom
nazaralwi wants to merge 2 commits intoswiftlang:mainfrom
Conversation
nazaralwi
requested review from
ahoppen,
hamishknight,
hborla and
rintaro
as code owners
rintaro
reviewed
Feb 20, 2026
| { (x: Int, y: Int) -> Int in | ||
| return x + y | ||
| } | ||
| ``` |
Member
There was a problem hiding this comment.
Could you clarify which parts of the example are ClosureParameterSyntax?
|
|
||
| ```swift | ||
| { (x: Int, y: Int) in x + y } | ||
| ``` |
| let doubled = numbers.map { [weak self] x -> Int in | ||
| return x * 2 | ||
| } | ||
| ``` |
| } | ||
| ``` | ||
|
|
||
| Everything before the `in` keyword is part of the closure signature. |
Member
There was a problem hiding this comment.
Everything after { and up to in.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As part of #1528, the documentation is added to Closure and Await Syntax nodes.
And I think some node names are outdated. Current mappings:
ClosureCaptureItemSpecifierSyntax→ClosureCaptureSpecifierSyntaxClosureCaptureItemSyntax→ClosureCaptureSyntaxClosureCaptureSignatureSyntax→ClosureCaptureClauseSyntaxClosureParamSyntax→ClosureShorthandParameterSyntax