Fix a miscompile when a test function has a raw identifier parameter label. #1168
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
grynspan
requested review from
stmontgomery,
briancroom and
suzannaratcliff
as code owners
grynspan
added
bug
|
@swift-ci test |
|
@swift-ci test macOS |
stmontgomery
approved these changes
Jun 24, 2025
|
@swift-ci test |
grynspan
added a commit
that referenced
this pull request
Jun 25, 2025
…label. (#1168) Resolves #1167. ### Checklist: - [x] Code and documentation should follow the style of the [Style Guide](https://github.com/apple/swift-testing/blob/main/Documentation/StyleGuide.md). - [x] If public symbols are renamed or modified, DocC references should be updated.
grynspan
added
the
parameterized-testing
grynspan
added a commit
that referenced
this pull request
Jun 25, 2025
…meter label. (#1173) - **Explanation**: Fixes parsing of function names to preserve backticks for raw parameter labels. - **Scope**: `@Test` macro and parameterized tests. - **Issues**: #1167 - **Original PRs**: #1168 - **Risk**: No obvious risk. - **Testing**: Standard CI jobs should verify the fix. - **Reviewers**: @briancroom @stmontgomery @hamishknight
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #1167.
Checklist: