Skip to content

[6.2] Fix a miscompile when a test function has a raw identifier parameter label. #1173

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 25, 2025
Merged

[6.2] Fix a miscompile when a test function has a raw identifier parameter label. #1173

merged 1 commit into from
Jun 25, 2025

Conversation

grynspan
Copy link
Contributor

@grynspan
Fix a miscompile when a test function has a raw identifier parameter …
ef124a8 
…label. (#1168)

Resolves #1167.

### Checklist:

- [x] Code and documentation should follow the style of the [Style
Guide](https://github.com/apple/swift-testing/blob/main/Documentation/StyleGuide.md).
- [x] If public symbols are renamed or modified, DocC references should
be updated.
@grynspan grynspan added this to the Swift 6.2 milestone Jun 25, 2025
@grynspan grynspan self-assigned this Jun 25, 2025
@grynspan grynspan added bug 🪲 Something isn't working parameterized-testing Related to parameterized testing functionality macros 🔭 Related to Swift macros such as @Test or #expect labels Jun 25, 2025
@grynspan
Copy link
Contributor Author

@swift-ci test

@grynspan grynspan added the integration ⚙️ Integrating work to release branches label Jun 25, 2025
@grynspan grynspan requested a review from hamishknight June 25, 2025 16:18
@grynspan grynspan added the raw-identifiers 🧅 Support for raw identifiers label Jun 25, 2025
@grynspan grynspan merged commit f2fb70d into release/6.2 Jun 25, 2025
3 checks passed
@grynspan grynspan deleted the jgrynspan/1167-raw-param-labels-6.2 branch June 25, 2025 18:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stmontgomery stmontgomery stmontgomery approved these changes

@briancroom briancroom briancroom approved these changes

@suzannaratcliff suzannaratcliff Awaiting requested review from suzannaratcliff suzannaratcliff is a code owner

@hamishknight hamishknight Awaiting requested review from hamishknight

Assignees

@grynspan grynspan

Labels
bug 🪲 Something isn't working integration ⚙️ Integrating work to release branches macros 🔭 Related to Swift macros such as @Test or #expect parameterized-testing Related to parameterized testing functionality raw-identifiers 🧅 Support for raw identifiers
Projects
None yet
Milestone
Swift 6.2.0
Development

Successfully merging this pull request may close these issues.
3 participants
@grynspan @stmontgomery @briancroom