Conversation
|
@swift-ci test |
b81b073 to
d54a0ba
Compare
|
@swift-ci test |
d54a0ba to
0856c1d
Compare
|
@swift-ci test |
935f2ab to
9066f51
Compare
|
@swift-ci test |
15b0eaa to
e6e2f85
Compare
|
@swift-ci test |
e6e2f85 to
eca0abb
Compare
|
@swift-ci test |
147f34d to
5ffab44
Compare
|
@swift-ci test |
5ffab44 to
f57489d
Compare
|
@swift-ci test |
…vend any instances publicly
| | `HOME`[\*](https://pubs.opengroup.org/onlinepubs/9799919799/basedefs/V1_chap08.html) | `String` | Used to determine the user's home directory. | | ||
| | `SIMULATOR_RUNTIME_BUILD_VERSION`\* | `String` | Used when running in the iOS (etc.) Simulator to determine the simulator's version. | | ||
| | `SIMULATOR_RUNTIME_VERSION`\* | `String` | Used when running in the iOS (etc.) Simulator to determine the simulator's version. | | ||
| | `SWT_SERIALIZED_TRAIT_APPLIES_GLOBALLY` | `Bool` | Whether or not `.serialized` applies globally or just to its branch of the test graph. | |
There was a problem hiding this comment.
While this is an experimental feature, should the env var name include the word "experimental"?
| // has an issue handling trait _and_ some other trait which caused an | ||
| // issue to be recorded, the issue handling trait can process the issue | ||
| // even though it wasn't recorded by the test function. | ||
| try await Test.withCurrent(step.test) { |
There was a problem hiding this comment.
Now that this _postingTestStartedAndEndedEvents function has been extracted, it looks like both of its call sites are now nested within try await Test.withCurrent(step.test) scopes. If that's true, then can you remove this withCurrent(...) call as redundant, now?
| var kind: Kind | ||
|
|
||
| /// The key path used to construct this dependency, if any. | ||
| nonisolated(unsafe) var originalKeyPath: AnyKeyPath? |
There was a problem hiding this comment.
Is there a reason to avoid storing this in case type(_:) of the Kind enum above? Is it because you can't use nonisolated(unsafe) on an enum case associated value?
| case (.some, .some): | ||
| // The two traits have different dependencies. Combine them into a single | ||
| // .unbounded dependency. | ||
| return .serialized(for: *) |
There was a problem hiding this comment.
It'll be good to include discussion of this behavior in any documentation article we eventually write, since I imagine folks will wonder what happens if two dependency serialization traits conflict.
Experimental
.serialized(for:)trait. Example use cases:Resolves rdar://135288463.
Checklist: