Fix test: issueCountSummingAtRunEnd which was broken by https://github.com/swiftlang/swift-testing/pull/1247 #1250
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
suzannaratcliff
requested review from
stmontgomery,
grynspan and
briancroom
as code owners
|
@swift-ci please test |
stmontgomery
added
bug
stmontgomery
approved these changes
Aug 5, 2025
grynspan
approved these changes
Aug 5, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix test: issueCountSummingAtRunEnd which was broken by #1247
Enabling warnings by default broke the test: issueCountSummingAtRunEnd. This fixes that.
Modifications:
I updated the expected output to contain warnings.
Checklist: