-
Notifications
You must be signed in to change notification settings - Fork 120
Emit a diagnostic if a display name string is empty #1256
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
stmontgomery
merged 7 commits into
swiftlang:main
from
stmontgomery:empty-display-string
Aug 13, 2025
Merged
Changes from 1 commit
Commits
Show all changes
7 commits
Select commit
Hold shift + click to select a range
ac892b6
Emit a warning if a display name string is empty
stmontgomery ba7214d
Use representedLiteralValue instead
stmontgomery 91b29e0
Add removal fix-it
stmontgomery 4b48d71
Improve diagnostic message for consistency
stmontgomery 8b2cdf2
Improve phrasing
stmontgomery cb45a57
Add fix-it which fills in the display name
stmontgomery 8ab1a4c
Switch warning severity to error
stmontgomery File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
30 changes: 30 additions & 0 deletions
30
Sources/TestingMacros/Support/Additions/StringLiteralExprSyntaxAdditions.swift
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,30 @@ | ||
// | ||
// This source file is part of the Swift.org open source project | ||
// | ||
// Copyright (c) 2025 Apple Inc. and the Swift project authors | ||
// Licensed under Apache License v2.0 with Runtime Library Exception | ||
// | ||
// See https://swift.org/LICENSE.txt for license information | ||
// See https://swift.org/CONTRIBUTORS.txt for Swift project authors | ||
// | ||
|
||
import SwiftSyntax | ||
|
||
extension StringLiteralExprSyntax { | ||
/// Whether or not this string literal expression is completely empty. | ||
/// | ||
/// The value of this property is `false` even if the literal contains one or | ||
/// more interpolation segments whose evaluated expressions are an empty | ||
/// string. The value is only `true` if this string literal contains only one | ||
/// empty string segment. | ||
var isEmptyLiteral: Bool { | ||
guard segments.count == 1, | ||
case let .stringSegment(stringSegment) = segments.first, | ||
case let .stringSegment(text) = stringSegment.content.tokenKind | ||
else { | ||
return false | ||
} | ||
|
||
return text.isEmpty | ||
} | ||
} |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.