Allow attaching an IWICBitmapSource instance directly.
#1266
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This PR adjusts the experimental WIC bitmap attachment support I recently added so that a test author can attach an instance of `IWICBitmapSource` (which is the parent type of the already-supported `IWICBitmap`.) Protocols and conformances are adjusted to match. I could have left the protocols as-is, but then you'd have to convert an `IWICBitmapSource` to an `IWICBitmap` (by allocating a new COM object) then cast it back to an `IWICBitmapSource` (by calling `QueryInterface()` and juggling the refcount) in order to actually attach it.
grynspan
added
windows
|
@swift-ci test |
grynspan
commented
Aug 13, 2025
| /// - Important: This function consumes a reference to `self` even if the cast | ||
| /// fails. | ||
| consuming func cast(to _: IWICBitmapSource.Type) throws -> UnsafeMutablePointer<IWICBitmapSource> { | ||
| try self.withMemoryRebound(to: IUnknown.self, capacity: 1) { `self` in |
There was a problem hiding this comment.
The casts in this file to IUnknown are safe insofar as we use them to access fixed members of the COM vtable. The casts would become unsafe if we allowed the resulting pointers to escape and if any of the types we use them on have multiple non-virtual inheritance to IUnknown.
There was a problem hiding this comment.
Can we capture this in a code comment for future reference?
|
@swift-ci test |
stmontgomery
approved these changes
Aug 13, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adjusts the experimental WIC bitmap attachment support I recently added so that a test author can attach an instance of
IWICBitmapSource(which is the parent type of the already-supportedIWICBitmap.) Protocols and conformances are adjusted to match.This PR then explicitly adds conformances to every COM class in WIC that subclasses
IWICBitmapSourcesince we can't see COM class inheritance in Swift (yet?)I could have left the protocols as-is, but then you'd have to convert an
IWICBitmapSourceto anIWICBitmap(by allocating a new COM object) then cast it back to anIWICBitmapSource(by callingQueryInterface()and juggling the refcount) in order to actually attach it.Checklist: