Skip to content

Fix the path to VERSION.txt used in CMake. #1327

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Sep 17, 2025
Merged

Fix the path to VERSION.txt used in CMake. #1327

merged 3 commits into from
Sep 17, 2025

Conversation

grynspan
Copy link
Contributor

@grynspan grynspan commented Sep 17, 2025 •
edited
Loading

Fixes a bug introduced in #1320.

Checklist:

  • Code and documentation should follow the style of the Style Guide.
  • If public symbols are renamed or modified, DocC references should be updated.

@grynspan grynspan added this to the Swift 6.x (main) milestone Sep 17, 2025
@grynspan grynspan self-assigned this Sep 17, 2025
@grynspan grynspan added bug 🪲 Something isn't working build 🧱 Affects the project's build configuration or process labels Sep 17, 2025
@grynspan grynspan mentioned this pull request Sep 17, 2025
Merged
2 tasks
@grynspan
Copy link
Contributor Author

Merging before CI finishes as none of it uses CMake anyway so this won't affect it.

@grynspan grynspan added the self-reviewed PR was self-reviewed by a code owner label Sep 17, 2025
@grynspan grynspan merged commit 9a1fc35 into main Sep 17, 2025
17 of 18 checks passed
@grynspan grynspan deleted the jgrynspan/fix-version-txt-path-in-cmake branch September 17, 2025 20:04
@mhegazy
Copy link

mhegazy commented Sep 17, 2025

thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stmontgomery stmontgomery Awaiting requested review from stmontgomery stmontgomery is a code owner

@briancroom briancroom Awaiting requested review from briancroom briancroom is a code owner

@suzannaratcliff suzannaratcliff Awaiting requested review from suzannaratcliff suzannaratcliff is a code owner

@jerryjrchen jerryjrchen Awaiting requested review from jerryjrchen jerryjrchen is a code owner

Assignees

@grynspan grynspan

Labels
bug 🪲 Something isn't working build 🧱 Affects the project's build configuration or process self-reviewed PR was self-reviewed by a code owner
Projects
None yet
Milestone
Swift 6.x (main)
Development

Successfully merging this pull request may close these issues.
2 participants
@grynspan @mhegazy