Get exit tests functioning on OpenBSD. #1352
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adjusts the implementation of exit tests on OpenBSD so that they correctly spawn child processes there.
Without this change, exit tests all abnormally terminate with exit code 127.
ktrace
andkdump
report:OpenBSD is more strict in its handling of
posix_spawnattr_setsigdefault()
than our other target platforms. Specifically, the child process will self-terminate after forking but before execing if eitherSIGKILL
orSIGSTOP
is in the signal mask passed to that function. Other platforms silently ignore these signals (since their handlers cannot be set per POSIX anyway.)With this change, exit tests function correctly and Swift Testing's test suite passes with zero issues on OpenBSD. 🥳
Checklist: