Get exit tests functioning on OpenBSD. #1352
Merged
+7
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This PR adjusts the implementation of exit tests on OpenBSD so that they
correctly spawn child processes there.
Without this change, exit tests all abnormally terminate with exit code 127.
`ktrace` and `kdump` report:
```
63170 swift-testingPackageTes CALL sigaction(SIGHUP,0x932dd7e5ca0,0)
63170 swift-testingPackageTes STRU struct sigaction { handler=SIG_DFL, mask=0<>, flags=0<> }
63170 swift-testingPackageTes RET sigaction 0
63170 swift-testingPackageTes CALL sigaction(SIGINT,0x932dd7e5ca0,0)
63170 swift-testingPackageTes STRU struct sigaction { handler=SIG_DFL, mask=0<>, flags=0<> }
63170 swift-testingPackageTes RET sigaction 0
[...]
63170 swift-testingPackageTes CALL sigaction(SIGKILL,0x932dd7e5ca0,0)
63170 swift-testingPackageTes RET sigaction -1 errno 22 Invalid argument
63170 swift-testingPackageTes CALL exit(127)
```
OpenBSD is more strict in its handling of `posix_spawnattr_setsigdefault()` than
our other target platforms. Specifically, the child process will self-terminate
after forking but before execing if either `SIGKILL` or `SIGSTOP` is in the
signal mask passed to that function. Other platforms silently ignore these
signals (since their handlers cannot be set per POSIX anyway.)
With this change, exit tests function correctly and Swift Testing's test suite
passes with zero issues on OpenBSD. 🥳
grynspan
requested review from
stmontgomery,
briancroom,
suzannaratcliff and
jerryjrchen
as code owners
grynspan
added
bug
|
@3405691582 please review! |
3405691582
approved these changes
Oct 4, 2025
|
For future reference, here are a few other projects on GitHub that spawn processes the way we do and need to do something like this: https://github.com/mys-lang/mys/blob/f3cb604e95eadd9833466dbd43ac9f5913f31d60/mys/uv/src/unix/process.c#L801 |
|
Oh and hey our very own swift-llbuild: https://github.com/swiftlang/swift-llbuild/blob/9cd06072bc98869d6058ecf0cbb62533ca10c02f/src/llbuild3/LocalExecutor.cpp#L1084 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adjusts the implementation of exit tests on OpenBSD so that they correctly spawn child processes there.
Without this change, exit tests all abnormally terminate with exit code 127.
ktraceandkdumpreport:OpenBSD is more strict in its handling of
posix_spawnattr_setsigdefault()than our other target platforms. Specifically, the child process will self-terminate after forking but before execing if eitherSIGKILLorSIGSTOPis in the signal mask passed to that function. Other platforms silently ignore these signals (since their handlers cannot be set per POSIX anyway.)With this change, exit tests function correctly and Swift Testing's test suite passes with zero issues on OpenBSD. 🥳
Checklist: