Remove some uses of @unchecked Sendable and AnySequence.
#1358
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This PR removes some outstanding uses of `@unchecked Sendable` and of `AnySequence`. Ironically we still need `Test.testCases` to type-erase with `AnySequence` _in its implementation only_ for now because if we change it from `some Sequence<Test.Case>` to `any Sequence<Test.Case>` we get this diagnostic: > 🛑 Runtime support for parameterized protocol types is only available in macOS > 13.0.0 or newer
grynspan
requested review from
stmontgomery,
briancroom,
suzannaratcliff and
jerryjrchen
as code owners
grynspan
added
concurrency
stmontgomery
approved these changes
Oct 6, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR removes some outstanding uses of
@unchecked Sendableand ofAnySequence.Ironically we still need
Test.testCasesto type-erase withAnySequencein its implementation only for now because if we change it fromsome Sequence<Test.Case>toany Sequence<Test.Case>we get this diagnostic:Checklist: