Factor out bug report URL boilerplate into a utility function#1635
Open
stmontgomery wants to merge 1 commit intoswiftlang:mainfrom
Open
Factor out bug report URL boilerplate into a utility function#1635stmontgomery wants to merge 1 commit intoswiftlang:mainfrom
stmontgomery wants to merge 1 commit intoswiftlang:mainfrom
Conversation
Contributor
|
Does it need to be a function call? Can't it just be an internal global and we interpolate it in? |
Contributor
|
Or even better, just have |
Contributor
Author
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Many places in the codebase terminate the program (via
fatalError,precondition, orassert) or throwSystemErrorand include a message asking the developer to file a bug report. The URL and surrounding boilerplate text for this request are duplicated verbatim across 18 call sites.This PR factors this into a utility function to reduce repetition and make it easier to include these helpful messages consistently when adding new assertion sites in the future.
Checklist: