timeLimitExceeded associated value changed in a source-breaking way.#1636
Merged
timeLimitExceeded associated value changed in a source-breaking way.#1636
timeLimitExceeded associated value changed in a source-breaking way.#1636Conversation
This PR restores the type of the associated value of `Issue.Kind.timeLimitExceeded()`. For source compatibility, this associated value must be a 2-tuple in perpetuity even though we can otherwise use `Duration` in our API surface. When we get to the next major language mode, we can potentially introduce a source-breaking change here.
grynspan
requested review from
briancroom,
harlanhaskins,
jerryjrchen and
stmontgomery
as code owners
grynspan
added
the
issue-handling
Contributor
harlanhaskins
left a comment
harlanhaskins
left a comment
There was a problem hiding this comment.
Oh, that's unfortunate.
stmontgomery
approved these changes
Mar 19, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR restores the type of the associated value of
Issue.Kind.timeLimitExceeded(). For source compatibility, this associated value must be a 2-tuple in perpetuity even though we can otherwise useDurationin our API surface.When we get to the next major language mode, we can potentially introduce a source-breaking change here.
Caused by #1606.
Checklist: