Un-revert "Replace rethrows with typed throws in Graph" #692
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 70f173e.
stmontgomery
added
enhancement
|
@swift-ci please test |
|
Toolchain builds have been triggered on swiftlang/swift#76484 |
grynspan
approved these changes
Sep 16, 2024
stmontgomery
requested review from
dennisweissmann,
briancroom,
SeanROlszewski and
suzannaratcliff
as code owners
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This un-reverts the changes originally landed in #662. Those changes were reverted in #679 due to a compiler issue which broke CI builds. We believe that compiler issue has been resolved via a revert in the Swift repo, made in swiftlang/swift#76435.
Before landing this (currently draft) PR, I plan to validate that Swift's CI is no longer affected using a cross-repo CI toolchain build.
Checklist: