Add support for attachments to the Foundation cross-import overlay. #819
Conversation
grynspan
added
enhancement
grynspan
requested review from
stmontgomery,
dennisweissmann,
briancroom,
SeanROlszewski and
suzannaratcliff
as code owners
|
@swift-ci test |
This PR adds experimental support for attachments to some types in Foundation via the (non-functional) cross-import overlay. @stmontgomery is working on setting up said overlay so that it can actually be used; until then, the changes here are speculative only.
grynspan
force-pushed
the
jgrynspan/foundation-attachment-overlay
branch
from
e432ce2 to
1421970
Compare
|
@swift-ci test |
|
@swift-ci test |
… separate library targets
|
@swift-ci test |
|
@swift-ci test |
Sources/Overlays/_Testing_Foundation/Attachments/Attachable+Encodable&NSSecureCoding.swift
Outdated
Show resolved
Hide resolved
Sources/Overlays/_Testing_Foundation/Attachments/Attachable+Encodable&NSSecureCoding.swift
Outdated
Show resolved
Hide resolved
Sources/Overlays/_Testing_Foundation/Attachments/Attachable+Encodable.swift
Show resolved
Hide resolved
Sources/Overlays/_Testing_Foundation/Attachments/EncodingFormat.swift
Outdated
Show resolved
Hide resolved
Sources/Overlays/_Testing_Foundation/Attachments/Attachable+NSSecureCoding.swift
Show resolved
Hide resolved
Sources/Overlays/_Testing_Foundation/Attachments/Attachable+NSSecureCoding.swift
Show resolved
Hide resolved
| return (preferredName as NSString).appendingPathExtension("tgz") ?? preferredName | ||
| }() | ||
|
|
||
| try await self.init(Data(compressedContentsOfDirectoryAt: url), named: preferredName, sourceLocation: sourceLocation) |
There was a problem hiding this comment.
Am I interpreting correctly that for directories, it unconditionally compresses the directory's contents? Could we make the compression step an optional parameter, but enabled by default? (Thinking of scenarios where you're attaching a directory containing files which are already highly compressed.) Maybe disabling that would use .tar instead of .tgz?
There was a problem hiding this comment.
This is consistent with what XCTest does here: https://developer.apple.com/documentation/xctest/xctattachment/2887210-init
There was a problem hiding this comment.
This can be for a future PR, but I'd like to request we revisit that and consider making it configurable. In general, "XCTest did it this way" isn't the most compelling justification 😛
|
@swift-ci test |
grynspan
added
the
cross-import-overlays
This PR adds experimental support for attachments to some types in Foundation via the (non-functional) cross-import overlay. @stmontgomery is working on setting up said overlay so that it can actually be used; until then, the changes here are speculative only.
Replaces #799.
Checklist: