Add an attribute that emits a warning. #895
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This PR adds an attribute (an overload of `@__testing()`) that emits a warning.
This allows us to emit compile-time warnings from contexts where only attributes
are semantically valid.
We need this in particular for test content records because their section info
is comprised of a big `IfConfigDecl` node and platforms that aren't covered
(i.e. the `#else` clause) don't have a way to emit a diagnostic that says "we
need to fix this platform's Swift Testing port!" like we can do in other
contexts with `#warning()`:
```swift
@_section("__DATA_CONST,__swift5_tests")
@_section("swift5_tests")
@_section(".sw5test$B")
// ⚠️ #warning isn't valid here, what do we do!?
@_used
private static let record: __TestContentRecord = (...)
```
grynspan
added
enhancement
grynspan
requested review from
stmontgomery,
dennisweissmann,
briancroom,
SeanROlszewski and
suzannaratcliff
as code owners
|
@swift-ci test |
stmontgomery
reviewed
Jan 7, 2025
stmontgomery
reviewed
Jan 7, 2025
stmontgomery
approved these changes
Jan 7, 2025
briancroom
approved these changes
Jan 7, 2025
|
@swift-ci test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds an attribute (an overload of
@__testing()) that emits a warning. This allows us to emit compile-time warnings from contexts where only attributes are semantically valid.We need this in particular for test content records because their section info is comprised of a big
IfConfigDeclnode and platforms that aren't covered (i.e. the#elseclause) don't have a way to emit a diagnostic that says "we need to fix this platform's Swift Testing port!" like we can do in other contexts with#warning():Checklist: