Skip to content

Add a missing #if !SWT_NO_EXIT_TESTS. #896

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 7, 2025
Merged

Add a missing #if !SWT_NO_EXIT_TESTS. #896

merged 1 commit into from
Jan 7, 2025

Conversation

grynspan
Copy link
Contributor

@grynspan grynspan commented Jan 7, 2025 •
edited
Loading

This PR adds a missing #if !SWT_NO_EXIT_TESTS statement in order to resolve a build failure on platforms that do not support exit tests (such as WASI.)

Checklist:

  • Code and documentation should follow the style of the Style Guide.
  • If public symbols are renamed or modified, DocC references should be updated.

@grynspan
Add a missing #if !SWT_NO_EXIT_TESTS.
f7892db 
This PR adds a missing `#if !SWT_NO_EXIT_TESTS` statement in order to resolve a
build failure on platforms that do not support exit tests (such as WASI.)
@grynspan grynspan added bug 🪲 Something isn't working darwin 🍎 macOS, iOS, watchOS, tvOS, and visionOS support wasi/wasm 🧭 WebAssembly support build 🧱 Affects the project's build configuration or process exit-tests ☠️ Work related to exit tests android 🤖 Android support labels Jan 7, 2025
@grynspan grynspan added this to the Swift 6.x milestone Jan 7, 2025
@grynspan grynspan self-assigned this Jan 7, 2025
@grynspan
Copy link
Contributor Author

grynspan commented Jan 7, 2025

@swift-ci test

@grynspan grynspan merged commit 200fdd7 into main Jan 7, 2025
3 checks passed
@grynspan grynspan deleted the jgrynspan/unbreak-wasi branch January 7, 2025 20:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stmontgomery stmontgomery stmontgomery approved these changes

@dennisweissmann dennisweissmann Awaiting requested review from dennisweissmann

@briancroom briancroom Awaiting requested review from briancroom briancroom is a code owner

@SeanROlszewski SeanROlszewski Awaiting requested review from SeanROlszewski

@suzannaratcliff suzannaratcliff Awaiting requested review from suzannaratcliff suzannaratcliff is a code owner

Assignees

@grynspan grynspan

Labels
android 🤖 Android support bug 🪲 Something isn't working build 🧱 Affects the project's build configuration or process darwin 🍎 macOS, iOS, watchOS, tvOS, and visionOS support exit-tests ☠️ Work related to exit tests wasi/wasm 🧭 WebAssembly support
Projects
None yet
Milestone
Swift 6.2.0
Development

Successfully merging this pull request may close these issues.
2 participants
@grynspan @stmontgomery