Skip to content

[ASTGen/Parse] Implement ASTGen changes for integer generics from Swift Syntax and restrict parsing integer types in certain contexts #77149

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 10 commits into from
Nov 7, 2024
Merged

[ASTGen/Parse] Implement ASTGen changes for integer generics from Swift Syntax and restrict parsing integer types in certain contexts #77149

merged 10 commits into from
Nov 7, 2024

Conversation

@Azoy
Copy link
Contributor

@Azoy Azoy commented Oct 21, 2024

In support of the Swift syntax parser being able to parse integer changes, we need to handle those in ASTGen.

Syntax PR: swiftlang/swift-syntax#2859

@Azoy Azoy mentioned this pull request Oct 21, 2024
Merged
@Azoy
Copy link
Contributor Author

Azoy commented Oct 21, 2024

Please test with the following pull request:
swiftlang/swift-syntax#2859

@swift-ci please test

1 similar comment
@Azoy
Copy link
Contributor Author

Azoy commented Oct 21, 2024

Please test with the following pull request:
swiftlang/swift-syntax#2859

@swift-ci please test

@rintaro
Copy link
Member

rintaro commented Oct 22, 2024

Please add tests in lib/ASTGen/.
Also, could we remove -disable-experimental-parser-round-trip in the following tests now?

test/Interpreter/value_generics.swift
test/ModuleInterface/value_generics.swift
test/Sema/value_generics.swift
test/Serialization/value_generics.swift

rintaro
rintaro reviewed Oct 22, 2024
View reviewed changes
@Azoy Azoy mentioned this pull request Oct 22, 2024
Closed
@Azoy Azoy changed the title [ASTGen] Implement ASTGen changes for integer generics from Swift Syntax [ASTGen/Parse] Implement ASTGen changes for integer generics from Swift Syntax and restrict parsing integer types in certain contexts Oct 22, 2024
rintaro
rintaro reviewed Oct 25, 2024
View reviewed changes
Copy link
Member

@rintaro rintaro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lib/Parse and lib/ASTGen changes look good to me. Thanks!
Still missing test/ASTGen test cases. Also just a small issues in SwiftMacros

@Azoy
Copy link
Contributor Author

Azoy commented Oct 28, 2024

Please test with the following pull request:
swiftlang/swift-syntax#2859
swiftlang/swift-format#866

@swift-ci please test

1 similar comment
@Azoy
Copy link
Contributor Author

Azoy commented Nov 4, 2024

Please test with the following pull request:
swiftlang/swift-syntax#2859
swiftlang/swift-format#866

@swift-ci please test

@Azoy Azoy force-pushed the swift-syntax-integer-types branch from b2673a4 to 676aa88 Compare November 5, 2024 01:14
@Azoy
Copy link
Contributor Author

Azoy commented Nov 5, 2024

Please test with the following pull request:
swiftlang/swift-syntax#2859
swiftlang/swift-format#866

@swift-ci please test

rintaro
rintaro approved these changes Nov 6, 2024
View reviewed changes
Copy link
Member

@rintaro rintaro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for doing this!

@Azoy Azoy force-pushed the swift-syntax-integer-types branch from 676aa88 to 13406e3 Compare November 6, 2024 21:56
@Azoy
Copy link
Contributor Author

Azoy commented Nov 6, 2024

Please test with the following pull request:
swiftlang/swift-syntax#2859
swiftlang/swift-format#866

@swift-ci please test

@ahoppen ahoppen merged commit fb0b3fa into swiftlang:main Nov 7, 2024
5 checks passed
@Azoy Azoy deleted the swift-syntax-integer-types branch November 7, 2024 22:11
@ahoppen ahoppen mentioned this pull request Nov 12, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@rintaro rintaro rintaro approved these changes

@ahoppen ahoppen Awaiting requested review from ahoppen

@bnbarham bnbarham Awaiting requested review from bnbarham bnbarham is a code owner

@CodaFi CodaFi Awaiting requested review from CodaFi CodaFi is a code owner

@hamishknight hamishknight Awaiting requested review from hamishknight hamishknight is a code owner

@hborla hborla Awaiting requested review from hborla hborla is a code owner

@slavapestov slavapestov Awaiting requested review from slavapestov slavapestov is a code owner

@xedin xedin Awaiting requested review from xedin xedin is a code owner

@xymus xymus Awaiting requested review from xymus xymus is a code owner

@DougGregor DougGregor Awaiting requested review from DougGregor DougGregor is a code owner

@jckarter jckarter Awaiting requested review from jckarter jckarter is a code owner

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@Azoy @rintaro @ahoppen