Skip to content

[build.ps1] build swift-lmdb using cmake #77562

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 4 commits into
base: main
Choose a base branch
from
Draft

[build.ps1] build swift-lmdb using cmake #77562

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
506b79e
build swift-lmdb using cmake
matthewbastien Nov 12, 2024
4f605ad
use Build-CMakeProject instead of Build-SPMProject
matthewbastien Nov 12, 2024
edeef31
add define for LMDB_DIR when building indexstore-db
matthewbastien Nov 13, 2024
4d937c8
fix lmdb build
matthewbastien Nov 13, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 12 additions & 0 deletions utils/build.ps1
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2439,6 +2439,17 @@ function Test-Format {
}
}

function Build-LMDB() {
Build-SPMProject `
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should this be Build-CMakeProject? This doesn't match the commit message. Do you have numbers for what the toolchain size impact is on static vs dynamic builds?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch! Admittedly I'm quite new to this and haven't been able to compile Swift on Windows at all. So, I don't have those numbers right now.

-Action Build `
-Src $SourceCache\swift-lmdb `
-Bin (Get-HostProjectBinaryCache LMDB) `
-Arch $HostArch `
-Platform Windows `
-UseBuiltCompilers C `
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there a reason to use clang-cl instead of cl here?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No particular reason. I've updated this patch to use the same approach you took in #71422.

One question about that PR: how close is it to being able to merge? I realize that the next step of this will probably be to get a cmake build of swift-docc working since the goal is to use swift-docc as a dependency to SourceKit-LSP which currently has a cmake build.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Honestly, I think it depends on the help that I can get for the reviews and convincing people of the need :). I think that I can likely get the patches working in a few days - I've been building with an older outdated version for quite some time. If you are willing to help with getting the changes merged, I think that we should be able to do this relatively painlessly.

-BuildTargets default
}

function Build-IndexStoreDB($Arch) {
$SDKInstallRoot = (Get-HostSwiftSDK);

Expand Down Expand Up @@ -2837,6 +2848,7 @@ if (-not $SkipBuild) {
Invoke-BuildStep Build-PackageManager $HostArch
Invoke-BuildStep Build-Markdown $HostArch
Invoke-BuildStep Build-Format $HostArch
Invoke-BuildStep Build-LMDB $HostArch
Invoke-BuildStep Build-IndexStoreDB $HostArch
Invoke-BuildStep Build-SourceKitLSP $HostArch
}
Expand Down