[cxx-interop] Support SIMD types in reverse interop #83586
+259
−58
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Xazax-hun
force-pushed
the
reverse-interop-better-simd
branch
from
59ebd61 to
5b0a382
Compare
Xazax-hun
changed the title
Xazax-hun
requested review from
zoecarver,
egorzhdan,
j-hui,
fahadnayyar,
susmonteiro,
hnrklssn and
rjmccall
as code owners
|
@swift-ci please smoke test |
hnrklssn
reviewed
Aug 8, 2025
This supports both built-in vector types and the SIMDX<T> Swift types that are used through type aliases like float3. These SIMD types are passed via compatibility structs (with their valued memcpy-d into the ABI compatible struct) as they have special ABI rules. E.g., a float3 is not passed as float3, but as float4 on the ABI level. Previously, we did not expose simd types from Swift to C++ (unless the SIMD types were impoted from clang). rdar://153218744
Xazax-hun
force-pushed
the
reverse-interop-better-simd
branch
from
5b0a382 to
39d90cc
Compare
|
@swift-ci please smoke test |
|
@swift-ci please smoke test Windows |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This supports both built-in vector types and the SIMDX Swift types
that are used through type aliases like float3. These SIMD types are
passed via compatibility structs (with their valued memcpy-d into the
ABI compatible struct) as they have special ABI rules. E.g., a float3 is
not passed as float3, but as float4 on the ABI level.
Previously, we did not expose simd types from Swift to C++ (unless the
SIMD types were impoted from clang).
rdar://153218744