macOS smoketest: enable Distributed and Synchronization in runtimes #83604
+27
−6
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
edymtt
requested review from
etcwilde,
compnerd and
justice-adams-apple
as code owners
compnerd
reviewed
Aug 7, 2025
edymtt
force-pushed
the
edymtt/build-distributed-synchronization-in-new-runtimes-build
branch
from
61c1ef4 to
9cf94b2
Compare
|
@swift-ci please smoke test |
|
@swift-ci please build toolchain Windows |
compnerd
reviewed
Aug 8, 2025
edymtt
force-pushed
the
edymtt/build-distributed-synchronization-in-new-runtimes-build
branch
from
9cf94b2 to
242cf74
Compare
|
@swift-ci please smoke test |
|
@swift-ci please build toolchain Windows |
compnerd
approved these changes
Aug 8, 2025
To make this work: * expose SwiftCMakeConfig.h from the Core build system, to support scenarios in which the downstream Distributed build is leveraging the config files generated by CMake itself. * adjust how SwiftShims is defined in `FindSwiftCore.cmake`, so that the shims are found from C++ and that we don't get redefinition errors when multiple module maps are in the search paths. Fixes swiftlang#83449 Addresses rdar://149241603, rdar://157165530
edymtt
force-pushed
the
edymtt/build-distributed-synchronization-in-new-runtimes-build
branch
from
242cf74 to
48fd452
Compare
|
@swift-ci please smoke test |
|
@swift-ci please build toolchain Windows |
|
@swift-ci please smoke test macOS |
|
@swift-ci please smoke test Windows |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To make this work:
FindSwiftCore.cmake, so that the shims are found from C++ and that we don't get redefinition errors when multiple module maps are in the search paths.Fixes #83449
Addresses rdar://149241603, rdar://157165530