[IDE] Perform extension binding after AST mutation #83613
+95
−77
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hamishknight
requested review from
bnbarham,
rintaro,
CodaFi,
DougGregor,
artemcm,
tshortli,
hborla,
slavapestov and
xedin
as code owners
This ought to be requestified, but for now let's split it into its own function.
This allows us to lazily bind extensions after mutating the AST, ensuring we don't prematurely kick the building of lookup tables.
Now that we correctly bind extensions after mutating the AST, this is no longer necessary.
hamishknight
force-pushed
the
next-step
branch
from
3746520 to
deecd46
Compare
|
@swift-ci please test |
|
@swift-ci please SourceKit stress test |
hamishknight
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
IDEInspectionSecondPassRequestunfortunately currently relies on mutating the AST after-the-fact, make sure we delay extension binding until after that has happened to ensure we don't attempt to prematurely build incomplete lookup tables. This also allows us to get rid of the ad-hoc extension binding logic intypeCheckContextAt.