[cxx-interop] Export empty enums as namespaces #83616
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It is a common idiom in Swift to use empty enums as namespaces. Previously, we just exported all zero sized types as unavailable declarations so users had no way to access anything in these "namespaces". This PR changes reverse interop to treat empty enums as namespaces. rdar://147499583
Xazax-hun
requested review from
zoecarver,
egorzhdan,
j-hui and
fahadnayyar
as code owners
Xazax-hun
requested review from
susmonteiro,
hnrklssn,
hborla,
slavapestov and
xedin
as code owners
|
@swift-ci please smoke test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It is a common idiom in Swift to use empty enums as namespaces. Previously, we just exported all zero sized types as unavailable declarations so users had no way to access anything in these "namespaces". This PR changes reverse interop to treat empty enums as namespaces.
rdar://147499583