[Cmake] Use correct magic symbols file for Concurrency #83619
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
justice-adams-apple
requested review from
etcwilde,
compnerd and
edymtt
as code owners
|
I think that we should use the Concurrency specific one for concurrency. I don't think that both are needed. |
|
@compnerd we'll need the other one for core, I guess my question is if they should be unified so we only need one file used by every project within Core/ ? |
|
@swift-ci please Smoke test |
|
I suspect that we can get away with a single one, but I think that having them be separate is better long term. The idea is that we can have different compatibility per library that and handle that at a per-module basis. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We want to use this magic symbols file, not this one.
Outstanding question: Do we need both?