[ConstraintSystem] Adjust isArgumentOfImportedDecl to handle synthesized declarations
#83620
+42
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…sized declarations If the declaration was synthesized for an imported type, let's consider it imported as well even though there is no direct clang declaration backing it. This allows us to support features like pointer conversions that are gated on the declarations being imported from C. Resolves: swiftlang#83221 Resolves: rdar://156356307
xedin
requested review from
hborla,
zoecarver,
egorzhdan,
beccadax,
ian-twilightcoder,
Xazax-hun,
j-hui,
fahadnayyar and
susmonteiro
as code owners
|
@swift-ci please test |
Xazax-hun
approved these changes
Aug 11, 2025
Xazax-hun
reviewed
Aug 11, 2025
There was a problem hiding this comment.
The change looks good to me but I am a bit unsure why we want to allow these conversions implicitly. The equivalent of a raw pointer in C++ would probably be something like void* and even C++ requires explicit casts from void to a different type.
What is the motivation here to be less safe than C++ in interop?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If the declaration was synthesized for an imported type,
let's consider it imported as well even though there is
no direct clang declaration backing it.
This allows us to support features like pointer conversions
that are gated on the declarations being imported from C.
Resolves: #83221
Resolves: rdar://156356307