[cmake] APIDigester, IDE: Specify Clang link dependencies #83645
+16
−5
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AnthonyLatsis
force-pushed
the
jepa-rebranch
branch
2 times, most recently
from
9b3a088 to
bd00138
Compare
|
@swift-ci please test Windows |
AnthonyLatsis
force-pushed
the
jepa-rebranch
branch
from
bd00138 to
68f3cbc
Compare
|
@swift-ci please test Windows |
|
@swift-ci please test Windows |
AnthonyLatsis
force-pushed
the
jepa-rebranch
branch
from
68f3cbc to
72196c9
Compare
|
@swift-ci please test Windows |
AnthonyLatsis
force-pushed
the
jepa-rebranch
branch
from
72196c9 to
228b0b5
Compare
|
@swift-ci please test Windows |
AnthonyLatsis
force-pushed
the
jepa-rebranch
branch
from
228b0b5 to
c00fc40
Compare
|
@swift-ci please test Windows |
This way, CMake will propagate the interface compile definitions of the Clang dependencies, which is important on Windows because Clang visibility macro expansions, controlled by compile definitions, must match between the Swift and Clang library. See https://github.com/llvm/llvm-project/pull/108276/files#diff-4dd645a8b76bb3886a505258a8c2e598aeddea770e7b0a2b51689124a5ea6e9a.
AnthonyLatsis
force-pushed
the
jepa-rebranch
branch
from
c00fc40 to
26de61d
Compare
AnthonyLatsis
changed the title
-DCLANG_BUILD_STATIC on Windows
|
@swift-ci please smoke test |
|
@swift-ci please test Windows |
compnerd
approved these changes
Aug 12, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This way, CMake will propagate the interface compile definitions of the Clang dependencies, which is important on Windows because Clang visibility macro expansions, controlled by compile definitions, must match between the Swift and Clang library.
See https://github.com/llvm/llvm-project/pull/108276/files#diff-4dd645a8b76bb3886a505258a8c2e598aeddea770e7b0a2b51689124a5ea6e9a.