Skip to content

[IDE] Add internal parameter names in signature help #84272

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Sep 15, 2025
Merged

[IDE] Add internal parameter names in signature help #84272

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
7dcc341
[IDE] Add internal parameter names in signature help
a7medev Sep 13, 2025
cb9afaa
[IDE] Add doc comments for SignatureHelpResponse
a7medev Sep 13, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
24 changes: 24 additions & 0 deletions test/SourceKit/SignatureHelp/signature_help_currying.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -82,6 +82,7 @@ func testCurryMemberFull() {
key.name: "add(_ self: Adder) -> (Int, Int) -> Int",
key.parameters: [
{
key.name: "self",
key.nameoffset: 4,
key.namelength: 13
}
Expand All @@ -92,6 +93,7 @@ func testCurryMemberFull() {
key.name: "add(_ self: Adder) -> (inout Int) -> ()",
key.parameters: [
{
key.name: "self",
key.nameoffset: 4,
key.namelength: 13
}
Expand All @@ -102,6 +104,7 @@ func testCurryMemberFull() {
key.name: "add(_ self: Adder) -> (AdditiveArithmetic, AdditiveArithmetic) -> AdditiveArithmetic",
key.parameters: [
{
key.name: "self",
key.nameoffset: 4,
key.namelength: 13
}
Expand All @@ -112,6 +115,7 @@ func testCurryMemberFull() {
key.name: "add(_ self: Adder) -> (Double?, Float, Int) -> Double",
key.parameters: [
{
key.name: "self",
key.nameoffset: 4,
key.namelength: 13
}
Expand All @@ -122,6 +126,7 @@ func testCurryMemberFull() {
key.name: "add(_ self: Adder) -> (Double, Float, Int) -> Double",
key.parameters: [
{
key.name: "self",
key.nameoffset: 4,
key.namelength: 13
}
Expand All @@ -132,6 +137,7 @@ func testCurryMemberFull() {
key.name: "add(_ self: Adder) -> (Double...) -> Double",
key.parameters: [
{
key.name: "self",
key.nameoffset: 4,
key.namelength: 13
}
Expand All @@ -142,6 +148,7 @@ func testCurryMemberFull() {
key.name: "add(_ self: Adder) -> (Int, Int, (Int, Int) throws -> Int) throws -> Int?",
key.parameters: [
{
key.name: "self",
key.nameoffset: 4,
key.namelength: 13
}
Expand All @@ -152,6 +159,7 @@ func testCurryMemberFull() {
key.name: "add(_ self: Adder) -> (Int) -> (Int) -> Int",
key.parameters: [
{
key.name: "self",
key.nameoffset: 4,
key.namelength: 13
}
Expand All @@ -168,10 +176,12 @@ func testCurryMemberFull() {
key.name: "(_ x: Int, to: Int) -> Int",
key.parameters: [
{
key.name: "x",
key.nameoffset: 1,
key.namelength: 8
},
{
key.name: "y",
key.nameoffset: 11,
key.namelength: 7
}
Expand All @@ -182,6 +192,7 @@ func testCurryMemberFull() {
key.name: "(oneTo: inout Int)",
key.parameters: [
{
key.name: "x",
key.nameoffset: 1,
key.namelength: 16
}
Expand All @@ -192,10 +203,12 @@ func testCurryMemberFull() {
key.name: "(_ x: AdditiveArithmetic, to: AdditiveArithmetic) -> AdditiveArithmetic",
key.parameters: [
{
key.name: "x",
key.nameoffset: 1,
key.namelength: 23
},
{
key.name: "y",
key.nameoffset: 26,
key.namelength: 22
}
Expand All @@ -206,14 +219,17 @@ func testCurryMemberFull() {
key.name: "(first: Double!, second: Float, third: Int) -> Double",
key.parameters: [
{
key.name: "first",
key.nameoffset: 1,
key.namelength: 14
},
{
key.name: "second",
key.nameoffset: 17,
key.namelength: 13
},
{
key.name: "third",
key.nameoffset: 32,
key.namelength: 10
}
Expand All @@ -224,14 +240,17 @@ func testCurryMemberFull() {
key.name: "(arg1: Double, arg2: Float, arg3: Int) -> Double",
key.parameters: [
{
key.name: "param1",
key.nameoffset: 1,
key.namelength: 12
},
{
key.name: "arg2",
key.nameoffset: 15,
key.namelength: 11
},
{
key.name: "param3",
key.nameoffset: 28,
key.namelength: 9
}
Expand All @@ -242,6 +261,7 @@ func testCurryMemberFull() {
key.name: "(numbers: Double...) -> Double",
key.parameters: [
{
key.name: "numbers",
key.nameoffset: 1,
key.namelength: 18
}
Expand All @@ -252,14 +272,17 @@ func testCurryMemberFull() {
key.name: "(x: Int, y: Int, with: (Int, Int) throws -> Int) throws -> Int!",
key.parameters: [
{
key.name: "x",
key.nameoffset: 1,
key.namelength: 6
},
{
key.name: "y",
key.nameoffset: 9,
key.namelength: 6
},
{
key.name: "adder",
key.nameoffset: 17,
key.namelength: 30
}
Expand All @@ -270,6 +293,7 @@ func testCurryMemberFull() {
key.name: "(x: Int) -> (Int) -> Int",
key.parameters: [
{
key.name: "x",
key.nameoffset: 1,
key.namelength: 6
}
Expand Down
16 changes: 16 additions & 0 deletions test/SourceKit/SignatureHelp/signature_help_default_args.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,10 +35,12 @@ add()
key.name: "add(_ x: Int = 10, to: Int) -> Int",
key.parameters: [
{
key.name: "x",
key.nameoffset: 4,
key.namelength: 13
},
{
key.name: "y",
key.nameoffset: 19,
key.namelength: 7
}
Expand All @@ -49,6 +51,7 @@ add()
key.name: "add(oneTo: inout Int)",
key.parameters: [
{
key.name: "x",
key.nameoffset: 4,
key.namelength: 16
}
Expand All @@ -59,10 +62,12 @@ add()
key.name: "add(_ x: Int, to: Int? = nil) -> String",
key.parameters: [
{
key.name: "x",
key.nameoffset: 4,
key.namelength: 8
},
{
key.name: "y",
key.nameoffset: 14,
key.namelength: 14
}
Expand All @@ -73,14 +78,17 @@ add()
key.name: "add(first: Double!, second: Float = .pi, third: Int) -> Double",
key.parameters: [
{
key.name: "first",
key.nameoffset: 4,
key.namelength: 14
},
{
key.name: "second",
key.nameoffset: 20,
key.namelength: 19
},
{
key.name: "third",
key.nameoffset: 41,
key.namelength: 10
}
Expand All @@ -91,6 +99,7 @@ add()
key.name: "add(s: S = S(a: false)) -> Double",
key.parameters: [
{
key.name: "s",
key.nameoffset: 4,
key.namelength: 18
}
Expand All @@ -101,14 +110,17 @@ add()
key.name: "add(x: Int, y: Int, with: (Int, Int) -> Int = { $0 + $1 }) -> Int",
key.parameters: [
{
key.name: "x",
key.nameoffset: 4,
key.namelength: 6
},
{
key.name: "y",
key.nameoffset: 12,
key.namelength: 6
},
{
key.name: "adder",
key.nameoffset: 20,
key.namelength: 37
}
Expand All @@ -119,6 +131,7 @@ add()
key.name: "add(x: Int = importantValue)",
key.parameters: [
{
key.name: "x",
key.nameoffset: 4,
key.namelength: 23
}
Expand All @@ -129,14 +142,17 @@ add()
key.name: "add(x: Int, line: UInt = #line, file: StaticString = #file)",
key.parameters: [
{
key.name: "x",
key.nameoffset: 4,
key.namelength: 6
},
{
key.name: "line",
key.nameoffset: 12,
key.namelength: 18
},
{
key.name: "file",
key.nameoffset: 32,
key.namelength: 26
}
Expand Down
2 changes: 2 additions & 0 deletions test/SourceKit/SignatureHelp/signature_help_doc.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,10 +30,12 @@ add(x: )
key.doc_comment: "Adds two integers.\n\n- Parameters:\n - x: The first integer to add.\n - y: The second integer to add.\n\nUsage:\n```swift\nadd(1, to: 2) // 3\n```\n\n- Returns: The sum of the two integers.",
key.parameters: [
{
key.name: "x",
key.nameoffset: 4,
key.namelength: 8
},
{
key.name: "y",
key.nameoffset: 14,
key.namelength: 7
}
Expand Down
4 changes: 4 additions & 0 deletions test/SourceKit/SignatureHelp/signature_help_enum_case.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,18 +26,22 @@ func testUnlabled() {
key.name: "upc(numberSystem: Int, manufacturer: Int, product: Int, check: Int) -> Barcode",
key.parameters: [
{
key.name: "numberSystem",
key.nameoffset: 4,
key.namelength: 17
},
{
key.name: "manufacturer",
key.nameoffset: 23,
key.namelength: 17
},
{
key.name: "product",
key.nameoffset: 42,
key.namelength: 12
},
{
key.name: "check",
key.nameoffset: 56,
key.namelength: 10
}
Expand Down
3 changes: 3 additions & 0 deletions test/SourceKit/SignatureHelp/signature_help_init.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,14 +17,17 @@ Person(name: "John", age: )
key.name: "init(name: String, age: Int, profession: String)",
key.parameters: [
{
key.name: "name",
key.nameoffset: 5,
key.namelength: 12
},
{
key.name: "age",
key.nameoffset: 19,
key.namelength: 8
},
{
key.name: "job",
key.nameoffset: 29,
key.namelength: 18
}
Expand Down
Loading