A few fixes for placeholder types in interface types #84345
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hamishknight
requested review from
AnthonyLatsis,
hborla,
slavapestov and
xedin
as code owners
|
@swift-ci please test source compatibility |
xedin
approved these changes
Sep 17, 2025
Avoid emitting a diagnostic about `<<hole>>` being a non-nominal type.
This never worked correctly and would crash in SILGen, ban the use of placeholder types. While here, ensure we replace any ErrorTypes with holes when solving the closure in the constraint system.
Ensure we can still produce a source location even if there's no name loc, which is the case for e.g enum associated types.
We allow resolving PlaceholderType here to allow MiscDiagnostics to suggest replacing it with the inferred result type, but we won't run that logic for non-FuncDecls and FuncDecls without bodies. Make sure we reject placeholders in those cases.
We allow placeholder types in interface types in certain cases to allow better recovery since we can suggest the inferred type as a replacement. When referencing those decls though we need to make sure we record a fix since we cannot form a valid solution with them.
We can't ever have default arguments in protocols anyway.
Avoid attempting to infer an associatedtype as a type that contains placeholders.
hamishknight
force-pushed
the
time-and-place
branch
from
fd4937f to
aa9aa58
Compare
|
@swift-ci please test |
|
swiftlang/swift-package-manager#9153 @swift-ci please smoke test Linux |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
extension _ {}