Introduce separately-imported stdlib overlays #84358
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
beccadax
requested review from
bnbarham,
hamishknight,
hborla,
ktoso,
rintaro,
slavapestov and
xedin
as code owners
|
@swift-ci please test |
beccadax
force-pushed
the
common-concurrency
branch
from
c1837c9 to
b2b53b7
Compare
|
@swift-ci please test |
DougGregor
approved these changes
Sep 18, 2025
hnrklssn
reviewed
Sep 25, 2025
beccadax
force-pushed
the
common-concurrency
branch
from
b2b53b7 to
00ac7a3
Compare
|
@swift-ci please test |
|
@swift-ci smoke test |
1 similar comment
|
@swift-ci smoke test |
beccadax
added a commit
to beccadax/sourcekit-lsp
that referenced
this pull request
Sep 30, 2025
swiftlang/swift#84358 makes the `_Concurrency` module behave like a cross-import overlay of `Swift`. This changes downstream behavior in SourceKit-LSP. Update a test to reflect that change.
|
With swiftlang/sourcekit-lsp#2313 @swift-ci please test |
The `_Concurrency` and `_StringProcessing` modules are implementation details of the standard library; to developers, their contents should behave as though they are declared directly within module `Swift`. This is the exact same behavior we expect of cross-import overlays, so treat these modules as though they are cross-import overlays with no bystanding module. Because these modules don’t re-export the standard library, it’s also necessary to treat `Swift` as a separately imported overlay of itself; do so and make that actually work.
beccadax
force-pushed
the
common-concurrency
branch
from
00ac7a3 to
3abbfaa
Compare
|
With swiftlang/sourcekit-lsp#2313 @swift-ci please smoke test |
beccadax
added a commit
to beccadax/sourcekit-lsp
that referenced
this pull request
Oct 6, 2025
swiftlang/swift#84358 makes the `_Concurrency` module behave like a cross-import overlay of `Swift`. This changes downstream behavior in SourceKit-LSP. Update a test to reflect that change.
beccadax
added a commit
to beccadax/sourcekit-lsp
that referenced
this pull request
Oct 6, 2025
swiftlang/swift#84358 makes the `_Concurrency` module behave like a cross-import overlay of `Swift`. This changes downstream behavior in SourceKit-LSP. Update a test to reflect that change.
|
This is ready to merge once the downstream swiftlang/sourcekit-lsp#2313 goes in. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
_Concurrencyand_StringProcessingmodules are implementation details of the standard library; to developers, their contents should behave as though they are declared directly within moduleSwift. This is the exact same behavior we expect of cross-import overlays, so treat these modules as though they are cross-import overlays with no bystanding module.Because these modules don’t re-export the standard library, it’s also necessary to treat
Swiftas a separately imported overlay of itself; do so and make that actually work.Offshoot of work on module selectors (#34556).