[CS] Consolidate placeholder handling logic into Solution::simplifyType
#84666
+159
−231
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hamishknight
requested review from
hborla,
slavapestov,
xedin,
AnthonyLatsis,
bnbarham and
rintaro
as code owners
|
@swift-ci please test |
|
@swift-ci please SourceKit stress test |
hamishknight
commented
Oct 3, 2025
| func f(_: Int...) {} | ||
| let _ = [(1, 2, 3)].map(f) // expected-error {{no exact matches in call to instance method 'map'}} | ||
| // expected-note@-1 {{found candidate with type '(((Int, Int, Int)) -> _) -> Array<_>'}} | ||
| // expected-note@-1 2{{found candidate with type '(((Int, Int, Int)) -> T) -> [T]'}} |
There was a problem hiding this comment.
We now get 2 notes here because T is a generic parameter from 2 different decls. We ought to be able to fix this by canonicalizing ErrorType's original type when computing the canonical type, I can look into that in a follow-up
Make sure we do this after we transform the type as otherwise we could skip resolving type variables and let them escape.
Move the logic from `FailureDiagnostic::resolveType` into `Solution::simplifyType` to allow completion to use it too. While here, also handle cases where the placeholder is from a different member of the equivalence class to the generic parameter.
We ought to be able to just use `simplifyType` with an additional parameter to tell it to produce archetypes.
hamishknight
force-pushed
the
can-opener
branch
from
f249498 to
9e4208b
Compare
|
@swift-ci please smoke test |
|
@swift-ci please test Linux |
|
@swift-ci please smoke test Linux |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Move the logic from
FailureDiagnostic::resolveTypeintoSolution::simplifyType, which then allows us to re-use it insimplifyTypeForCodeCompletion.